fix(acp): register grok preset args for grok-build runtime (#3457) - #3521
Open
1nderboi wants to merge 1 commit into
Open
fix(acp): register grok preset args for grok-build runtime (#3457)#35211nderboi wants to merge 1 commit into
1nderboi wants to merge 1 commit into
Conversation
- Adds default_agent_args for 'grok' command identity in both buzz-acp and desktop managed_agents discovery - Ensures bare grok invocations receive ['agent', '--always-approve', 'stdio'] instead of spawning TUI - Adds unit tests in both crates verifying Grok argument normalization Signed-off-by: 1nderboi <201919958+1nderboi@users.noreply.github.com> Co-authored-by: 1nderboi <201919958+1nderboi@users.noreply.github.com> Signed-off-by: 1nderboi <201919958+1nderboi@users.noreply.github.com>
Chessing234
reviewed
Jul 29, 2026
Chessing234
left a comment
Chessing234
left a comment
Contributor
There was a problem hiding this comment.
Matches the #3457 failure mode exactly — bare grok launches the TUI and dies with ENXIO under the harness. Registering agent --always-approve stdio in both buzz-acp and desktop discovery (with empty-arg normalization) is the right dual-site fix, and the unit tests pin it. LGTM.
Chessing234
approved these changes
Jul 29, 2026
Chessing234
left a comment
Chessing234
left a comment
Contributor
There was a problem hiding this comment.
Approving — dual-site grok preset args fix #3457 cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3457.
['agent', '--always-approve', 'stdio']for thegrokcommand identity in bothbuzz-acp(config.rs) and desktop managed agents discovery (discovery.rs).grokspawns from launching the interactive TUI mode (which hangs/fails with ENXIO) when no explicitagent_argsare configured.Signed-off-by: 1nderboi 201919958+1nderboi@users.noreply.github.com
Co-authored-by: 1nderboi 201919958+1nderboi@users.noreply.github.com