Run Tauri clippy in pre-push - #3555
Merged
Merged
Conversation
Reuse the CI-equivalent just recipe for all paths that can affect the Tauri crate so warnings rejected by CI are caught before push. Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
added a commit
that referenced
this pull request
Jul 29, 2026
## Summary - combine Desktop Tauri clippy and tests into one pre-push command - run clippy first, then tests - keep unrelated pre-push commands parallel ## Why PR #3555 added clippy as a separate command while the pre-push group uses `parallel: true`. That can start clippy and tests simultaneously against the same Cargo target directory, leaving one command waiting on Cargo's build lock and making pushes appear stalled. Serializing only these two Cargo-heavy checks avoids lock contention while retaining the CI-equivalent clippy command and existing test coverage. ## Validation - `lefthook validate` - forced `desktop-tauri-checks` through Lefthook with an instrumented `just`; observed `desktop-tauri-clippy` followed by `desktop-tauri-test` Signed-off-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
joahg
added a commit
to joahg/buzz
that referenced
this pull request
Jul 29, 2026
…-style * origin/main: chore(release): release Buzz Desktop version 0.5.1 (block#3566) Run Tauri clippy in pre-push (block#3555) perf(desktop): move observer-feed archive and decrypt commands off main thread (block#3415) fix(desktop): preserve shared agent fidelity (block#3553) Polish mobile navigation and menus (block#3486) feat(agent): route Claude/GPT model families to their native gateway wire (block#3538) Refine community invite limits (block#3529) Polish mobile typing indicator (block#3528) Signed-off-by: Joah Gerstenberg <joah@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just desktop-tauri-clippy, keeping the local command identical to Desktop Core CIWhy
PR #3553 exposed a hook gap:
cargo testallowed an unused-import warning that CI'sclippy -D warningscorrectly rejected. Running the same recipe before push catches that class of failure locally without duplicating CI flags in Lefthook.Validation
lefthook run pre-push --command desktop-tauri-clippy --forcecargo clippy --manifest-path desktop/src-tauri/Cargo.toml --all-targets -- -D warnings