fix(mobile): p-tag DM recipients so agents receive plain messages - #3604
fix(mobile): p-tag DM recipients so agents receive plain messages#3604Chessing234 wants to merge 1 commit into
Conversation
Desktop already tags every DM participant; mobile only added explicit @mentions, so agent DMs from the phone never woke a turn. Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Independent validation from a real Buzz mobile client, hosted Buzz relay, and the Fly Hermes identity:
That reproduces #3591 at the event boundary and confirms the failure is in mobile message construction, not relay delivery. This PR's helper matches the desktop rule: plain DMs address every other participant, explicit mentions remain deduplicated, self is excluded, and stream messages do not invent recipient tags. I mirrored the exact contributor commit into fork CI because the upstream workflow has not been approved yet. The mobile job passed, including file-size checks, format, analysis, Flutter tests, and an Android debug APK build. The overall fork workflow also ran unrelated desktop jobs; its macOS desktop build failed before compiling Buzz because the mesh-llm checkout was unavailable. One limitation: our Fly agent uses Hermes's native Buzz adapter, which already works around missing DM p tags by classifying the channel as a DM. Fly therefore still replied after its conversation was latched. This proves the malformed mobile event and the code correction, but it does not independently reproduce the managed ACP wake failure. After this fix, a plain mobile DM can say “Hello” without also spelling out @fly. |
Summary
messageMentionPubkeysrule to mobile: DM sends now includeptags for every other participant/member, not only explicit@mentionsTest plan
flutter test test/features/channels/message_mention_pubkeys_test.dart test/features/channels/send_message_provider_test.darthellowith no@mention— event carries["p", <agent>]and the agent repliesptags@Agentmentions in a DM still work and stay deduped with the auto recipientsFixes #3591
Made with Cursor