fix(acp): show mention_filter in startup config summary (#4228) - #4243
Open
Chessing234 wants to merge 5 commits into
Open
fix(acp): show mention_filter in startup config summary (#4228)#4243Chessing234 wants to merge 5 commits into
Chessing234 wants to merge 5 commits into
Conversation
Operators running --no-mention-filter need the journal line to attest that the #p gate is disabled; subscribe=Mentions alone is ambiguous (block#4228). Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Regression tests pin default mention_filter=on and off when --no-mention-filter is set, and assert the two modes differ (block#4228). Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Explain that operators can confirm --no-mention-filter from journal grep without an end-to-end probe (block#4228). Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Clap help text points operators at the startup summary field that confirms the #p gate is disabled (block#4228). Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Rustdoc on the summary helper explains the journal attestation contract for operators auditing mention-gated harnesses (block#4228). Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mention_filter=on|offto the buzz-acp startup journal line so--no-mention-filterdeployments are distinguishable from gatedsubscribe=Mentions.Config::summaryrustdoc.Fixes #4228.
Test plan
cargo test -p buzz-acp test_summary_mention_filtermention_filter=offwhen runningbuzz-acp --subscribe mentions --no-mention-filterMade with Cursor