Skip to content

fix(desktop): preserve terminal mode while tab attaches - #4405

Merged
tlongwell-block merged 1 commit into
max/tui-rendererfrom
mari/tui-tab-attach
Aug 2, 2026
Merged

fix(desktop): preserve terminal mode while tab attaches#4405
tlongwell-block merged 1 commit into
max/tui-rendererfrom
mari/tui-tab-attach

Conversation

@tlongwell-block

Copy link
Copy Markdown
Collaborator

Summary

  • keep the terminal substrate enabled while an active session is attaching
  • preserve terminal ownership and fade state when opening a new tab
  • add a mounted regression covering the pending-attachment interval

Verification

  • pnpm --dir desktop test — 3962 passed
  • pnpm --dir desktop typecheck
  • pnpm --dir desktop exec biome check src/features/terminal/TerminalBootstrap.tsx src/features/terminal/TerminalBootstrap.test.mjs
  • push hook: desktop checks/tests, mobile tests, desktop Tauri checks, and Rust tests passed

Originating Buzz channel: dbb5c335-bbce-4969-8635-7dae8338ea5b

Co-authored-by: npub1jh9wn95s0472h86ahapupaf7m6kx4v9sx2n0atj2hltcfer8k06s5n3pyf <95cae996907d7cab9f5dbf43c0f53edeac6ab0b032a6feae4abfd784e467b3f5@buzz.block.builderlab.xyz>
Signed-off-by: npub1jh9wn95s0472h86ahapupaf7m6kx4v9sx2n0atj2hltcfer8k06s5n3pyf <95cae996907d7cab9f5dbf43c0f53edeac6ab0b032a6feae4abfd784e467b3f5@buzz.block.builderlab.xyz>
@tlongwell-block
tlongwell-block requested a review from a team as a code owner August 2, 2026 20:48
@tlongwell-block
tlongwell-block merged commit 6d159d1 into max/tui-renderer Aug 2, 2026
18 of 19 checks passed
@tlongwell-block
tlongwell-block deleted the mari/tui-tab-attach branch August 2, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant