fix(desktop): fail fast in just dev on Linux when Tauri native deps are missing - #4415
Open
maxitoon wants to merge 1 commit into
Open
fix(desktop): fail fast in just dev on Linux when Tauri native deps are missing#4415maxitoon wants to merge 1 commit into
maxitoon wants to merge 1 commit into
Conversation
…re missing On Linux, just dev previously discovered missing GTK/WebKitGTK system libraries deep inside the Tauri cargo build as a cryptic pkg-config error. Add scripts/check-tauri-linux-deps.sh, a read-only guard wired into the dev recipe that checks for pkg-config and the modules backing the documented apt package list, then exits with the missing module names and the documented install line. The guard is a no-op on non-Linux platforms and never installs anything or calls sudo. Cover the guard with scripts/test-check-tauri-linux-deps.sh (mocked pkg-config over an isolated PATH, following the existing shell contract test conventions) and run it in the CI contract-test job. Update the CONTRIBUTING.md Linux section, which named just ci and the desktop-tauri-* recipes but omitted the just dev path. Refs block#4122 Signed-off-by: Hermes Agent <hermes-agent@localhost>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
On Linux,
just devcould reach the Tauri Cargo build before reporting missing GTK/WebKitGTK and related native development libraries. The resultingpkg-configfailure was late and difficult to remediate.Fixes #4122
Root Cause
The documented Linux package prerequisites existed, but
just devdid not validate them before running its bootstrap, migration and build prerequisites.Fix
scripts/check-tauri-linux-deps.sh, a read-only Linux preflight that checkspkg-configand the required Tauri modules.just dev.sudo.pkg-config, missing one or more modules and the all-present path.just devpath.How to Verify
The dry-run should begin with:
Test Plan
TMPDIRoverride, including on a host where/tmpisnoexec.bash -n.just devprerequisite order.just ci/ Rust / Flutter / Docker suite — unavailable in the contributor container because the required toolchains and Docker are not installed.Risk Assessment
Low — the change is limited to a read-only preflight, one
just devprerequisite, documentation and a CI contract test. Non-Linux platforms exit successfully without output, and no package manager, network call or privileged command is executed.Scope Notes
This is intentionally limited to
just devnative dependency detection and does not overlap with the separatebuzz doctorwork in #4063.