Skip to content

fix(auth): implement PKCE for Google Auth and sync latest upstream notifications - #4927

Closed
ranjank2alpha wants to merge 0 commit into
block:mainfrom
ranjank2alpha:main
Closed

fix(auth): implement PKCE for Google Auth and sync latest upstream notifications#4927
ranjank2alpha wants to merge 0 commit into
block:mainfrom
ranjank2alpha:main

Conversation

@ranjank2alpha

Copy link
Copy Markdown

Summary

  • Implements PKCE (code_challenge and code_verifier with S256 method) for native Google OAuth2 login flow in google_auth.rs.
  • Adds explicit HTTP status verification (status().is_success()) before parsing OAuth token exchange JSON responses to prevent unwrap crashes on 4xx responses.
  • Merges latest upstream main updates and resolves notification sound/active target check conflicts in use-feed-desktop-notifications.ts.

Testing

  • Code audit completed across Rust and TypeScript network boundary handlers.
  • Verified PKCE parameter generation and error body logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant