chore(hooks): run desktop typecheck in pre-push - #5110
Merged
Conversation
Pre-push only ran biome and node:test for desktop, so TypeScript errors surfaced no earlier than CI's desktop-build (tsc && vite build). Gate tsc --noEmit locally with the same glob as desktop-check. Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
pushed a commit
that referenced
this pull request
Aug 6, 2026
* origin/main: Alert community owners and admins when a new key joins (#4900) fix(desktop): prevent sidebar prefs from reverting on stale-localStorage boot (#5086) chore(hooks): run desktop typecheck in pre-push (#5110) feat(identity): recover desktop identity from a signed-in phone (#4845) Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local pre-push gate ran biome (
desktop-check) and node:test (desktop-test) for desktop changes but nevertsc, so TypeScript errors surface no earlier than CI'sdesktop-corejob (just desktop-build=tsc && vite build). A branch with type errors passes every local hook today.This adds a
desktop-typecheckpre-push command runningjust desktop-typecheck(tsc --noEmit) with the same glob/exclude asdesktop-check, and updates the hook documentation inAGENTS.md. CI is unchanged — it already typechecks viadesktop-build.