refactor(cli): replace probe/decider/detail split with single typed extractor - #5191
Merged
Conversation
When owner-auth extraction fails for a non-self target, the CLI now: 1. Retries the kind:0 fetch once (transient profile republish is the dominant failure mode and the retry resolves it silently). 2. If the retry also fails, returns a hard error naming the extraction failure and the --admin escape hatch — the bare request is NOT sent. This replaces the previous behaviour where extraction failure emitted a warning and then sent a bare request that the relay would reject with 400 unless the signer happened to be a relay admin. The --admin flag is added to both archive and unarchive. It restores the old warn-and-proceed-bare path for genuine relay-admin callers who legitimately archive without owner attestation. The self path (target == signer) is unchanged and always sends bare. Ten new unit tests cover resolve_auth_deciding and auth_failure_detail: first-success, retry-success, both-fail-no-admin (Err), both-fail-admin (Ok(None)+warning), no-kind0-fail, no-retry-sentinel, and four auth_failure_detail precision cases. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
…xtractor Replace the four-helper auth resolution path (resolve_auth_from_profile → resolve_auth_deciding → handle_auth_failure → auth_failure_detail) with two focused functions: - extract_auth(profile, target, signer) -> Result<[String;4], AuthFailure>: pure typed extractor; AuthFailure now covers NoProfile and NoTagsArray (previously handled via warn-emitting branches) alongside the existing tag-validation variants. - resolve_auth(): now the linear state machine itself — self-check → fetch + extract → on failure: fetch again → route final Err to CliError::Usage or one admin warning. No throwaway sinks, no duplicate classification, no Option<Option<_>> sentinel. Replace the sync resolve_auth_deciding/auth_failure_detail unit tests with five async tests that drive the production resolver through a counted Axum test server on POST /query. Each test asserts on both the return value and the exact number of /query calls: - first success → 1 fetch - retry success → 2 fetches - double failure, no --admin → 2 fetches + Err(CliError::Usage) - double failure, --admin → 2 fetches + Ok(None) + exactly one warning - self path → 0 fetches Add two parser tests pinning --admin on both archive and unarchive. Fix --admin short help to accurately describe when the flag takes effect (after extraction fails, not unconditionally). Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
changed the title
…_auth_profile Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
atishpatel
added a commit
that referenced
this pull request
Aug 7, 2026
…-log-harness * origin/main: feat(desktop): adding rich link previews to messages (#3818) fix(buzz-agent): Responses reasoning summary, Anthropic display:summarized, ACP v2 messageId (#5195) fix(desktop): retain distinct agent instances in autocomplete (#5202) fix(desktop): defer channel visibility change to Save (#5203) feat(desktop): Projects follow-ups — access restrictions, fast loading, activity feed polish (#5073) refactor(cli): replace probe/decider/detail split with single typed extractor (#5191) fix(desktop): drop unhandled rejection from throwing window.Notification (#5143) fix(desktop): fence localStorage SecurityError from killing the React tree (#5142) fix(desktop): make terminal output selectable (#4980) fix(desktop): use WEBKIT_DMABUF_RENDERER_FORCE_SHM for NVIDIA/AppImage (#3654) (#4505) Make public starter channels best effort (#5192) Mobile: add anchored reaction popover (#5025) feat(mobile): add bee pull-to-refresh (#5059) Signed-off-by: Atish Patel <atish@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the four-helper auth resolution path with two focused functions and adds production async tests that count relay round-trips.
Before:
resolve_authcalledresolve_auth_from_profile(warn-emitting probe into a throwaway sink) →resolve_auth_deciding(re-classified the same profile) →handle_auth_failure→auth_failure_detail(third classification).Option<Option<&Value>>encoded a sentinel for unreachable state; tests exercised only the pure sync helper, not the actual fetch count.After:
extract_auth(profile, target, signer) -> Result<[String;4], AuthFailure>— pure typed extractor;AuthFailurenow coversNoProfileandNoTagsArrayinline, no separate helper neededresolve_auth()is now the linear state machine: self-check → fetch + extract → on failure: fetch again → route finalErrtoCliError::Usage(default) or one admin warning (--admin). No throwaway sinks, no duplicate classification, no sentinel type.POST /queryand assert on both return value and exact fetch count: first success (1), retry success (2), double failure / no--admin(2 +Err), double failure /--admin(2 +Ok(None)+ one warning), self path (0). Two parser tests pin--adminon botharchiveandunarchive.--adminshort help text corrected to describe when the flag takes effect (after extraction fails, not unconditionally).341 tests passing, clippy clean, fmt clean.