fix(mobile): make non-member invitations explicit and cancellable - #7390
Draft
loganj wants to merge 3 commits into
Draft
fix(mobile): make non-member invitations explicit and cancellable#7390loganj wants to merge 3 commits into
loganj wants to merge 3 commits into
Conversation
Signed-off-by: Logan Johnson <loganj@squareup.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
🔐 Codex Security Review
|
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Size / stack
574 added + deleted lines including tests. Combines planned lifecycle + invitations into one independent draft, saving one PR. No merge requested.
Evidence
Full mobile package passed at 5b79fe5. Full local
just ciwas attempted: first run hit an unchanged ACP wire-lifecycle timeout; the rerun was terminated during Rust compilation, so no full-local-CI pass is claimed. The current head’s GitHub Mobile and other executed checks pass (security review is still required). Final cancellation regression proves upload initiation, zero membership events, zero sends and unchanged draft. Dialog tests cover Invite/reference-only/dismiss/refusal. Native simulator unavailable (no Xcode/simctl).Originating Buzz channel: f6cfbbe2-3f94-4b41-9105-e6dcc5459813.
Composed-stack evidence / landing note
Current review head:
5b79fe52adcc8c892694410b2e96035962d589f2; incremental size: 574 added + deleted lines.All 11 draft slices are composed on
verify/mobile-combined-20260905at40630565:just mobile-checkand the fulljust mobile-testpass (2,144 tests). This is integration evidence, not a twelfth review PR or native-device acceptance.Independent branches overlap, especially in the composer. Use that commit as the conflict-resolution reference when rebasing for landing; do not blindly choose one branch’s send function. Preserve exact/durable bindings, explicit Invite/reference-only intent, visit/account/community/revision fences, and authorization before membership preparation and before publication. Widened discovery must not roll out before #7390 + #7394 are integrated. Code dependency is only the declared PR base; overlapping files and rollout order are not extra dependency edges.
All PRs remain draft; no merge requested. Security/human review is not complete. Originating Buzz channel:
f6cfbbe2-3f94-4b41-9105-e6dcc5459813.