test(relay): isolate telemetry callsite registry assertions (#7404) - #7436
Open
bounce12340 wants to merge 1 commit into
Open
test(relay): isolate telemetry callsite registry assertions (#7404)#7436bounce12340 wants to merge 1 commit into
bounce12340 wants to merge 1 commit into
Conversation
Serialize subscriber-installing telemetry tests with a module-level Mutex so parallel cargo test cannot race tracing's process-global callsite Interest registry against thread-local with_default scopes. Fixes block#7404 Signed-off-by: Josh Tsai <bounce12340@users.noreply.github.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CALLSITE_LOCKaround telemetry tests that install subscribers / assert callsite Interest.with_defaultalone races under parallelcargo test.trace_context_json_correlates_nested_span_logsandtrace_context_lookup_does_not_enable_callsites.Closes #7404
Test plan
cargo test -p buzz-relay --lib telemetry -- --test-threads=8(or full relay suite) repeatedly without the flaketrace_context_lookup_does_not_enable_callsitesstill passes