fix(test): tolerate docker container creation races in s3clienttest#397
Merged
Conversation
Parallel test packages race to create the shared MinIO container. The loser's "docker start" can run before the winner's creation finishes registering the container, failing with "No such container". Retry the run/start cycle until the container is up or a deadline passes. Amp-Thread-ID: https://ampcode.com/threads/T-019f8b6a-3778-7200-a3b4-c24b84edd973 Co-authored-by: Amp <amp@ampcode.com>
alecthomas
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel test packages race to create the shared MinIO container. The loser's
docker startfallback can run before the winner's creation finishes registering the container, failing the test withNo such container: minio-test. Retry the run/start cycle until the container is up or a 30s deadline passes.Verified locally by removing the container and running both consuming packages in parallel (concurrent creation), and again with the container stopped (restart path).