fix: update OpenAPI spec models and restore mangled UpdateVirtualTagConfigValue export - #32
Merged
Merged
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…egen The upstream spec now defines the virtual tag value schema both inline and as named schemas, so datamodel-codegen emits *_value1_* twins and the wildcard exports mangle the plain class name out of the package interface. Pin a stable alias in common.py and re-export it. Also: - regenerate models from the current spec (new annotation models, recipient_emails on alerts) - make the weekly CI job run 'just regenerate-models' so it cleans gen_models before codegen and stays in sync with local tooling - remove the redundant generate-models recipe - re-record cassettes broken by new required response fields - document the name-collision failure mode in CONTRIBUTORS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #31 (closed; branch was force-pushed after closing so it could not be reopened).
The upstream Vantage spec now defines the virtual tag value schema twice (inline in
createVirtualTagConfig/updateVirtualTagConfigand as the namedcreateVirtualTagConfigValue/updateVirtualTagConfigValueschemas), which makes datamodel-codegen emit*_value1_*twin modules and mangle the colliding class names out of the package exports —UpdateVirtualTagConfigValuedisappeared from the public interface, breaking imports.Changes:
recipient_emailson alerts,*_value1_*twins)UpdateVirtualTagConfigValuealias incommon.pyand re-export itjust regenerate-modelsso it cleansgen_models/before codegen (the inline steps left stale deleted modules behind) and stays in sync with local tooling; remove the redundantgenerate-modelsrecipeOffline suite: 69 passed, 34 skipped. Format/lint/typecheck clean.