Wire JSON ingestion schema extension#1222
Closed
jwils wants to merge 3 commits into
Closed
Conversation
7f5b7f1 to
1fbcfe5
Compare
e3dee45 to
595ca74
Compare
1fbcfe5 to
9eabfa9
Compare
595ca74 to
5801306
Compare
9eabfa9 to
ffec0c4
Compare
5801306 to
b253655
Compare
b253655 to
29fb38e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the JSON ingestion gem exists, schema definition needs a concrete extension implementation so JSON Schema artifacts are generated through opt-in extension modules instead of core schema-definition code.
Stacked on #1221.
What
Verification
script/run_gem_specs elasticgraph-json_ingestion(skips because this extracted gem does not have its own spec directory yet)bundle exec rspec elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_spec.rb elasticgraph-schema_definition/spec/integration/elastic_graph/schema_definition/rake_tasks_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/factory_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/indexing/json_schema_with_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_field_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_pruner_spec.rb elasticgraph-indexer/spec/unit/elastic_graph/indexer/record_preparer_spec.rb elasticgraph-apollo/spec/unit/elastic_graph/apollo/apollo_directives_spec.rb elasticgraph-apollo/spec/unit/elastic_graph/apollo/schema_definition_spec.rbscript/type_checkscript/quick_buildpasses spellcheck, lint, type check, and schema artifact checks locally; it stops before the full spec run because the local Docker/test datastore is not running athttp://localhost:9234.