Skip to content

Wire JSON ingestion schema extension#1222

Closed
jwils wants to merge 3 commits into
joshuaw/json-ingestion-schema-supportfrom
joshuaw/json-ingestion-extension-stack
Closed

Wire JSON ingestion schema extension#1222
jwils wants to merge 3 commits into
joshuaw/json-ingestion-schema-supportfrom
joshuaw/json-ingestion-extension-stack

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 30, 2026

Why

After the JSON ingestion gem exists, schema definition needs a concrete extension implementation so JSON Schema artifacts are generated through opt-in extension modules instead of core schema-definition code.

Stacked on #1221.

What

  • Add JSON-ingestion indexing wrappers for fields, field references, and field types.
  • Add schema definition extension modules for API, factory, results, state, schema artifact management, and schema elements.
  • Wire generated projects and built-in gems to use JSON ingestion as a schema definition extension.
  • Remove JSON Schema behavior from core schema definition classes where the extension now owns it.

Verification

  • script/run_gem_specs elasticgraph-json_ingestion (skips because this extracted gem does not have its own spec directory yet)
  • bundle exec rspec elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_spec.rb elasticgraph-schema_definition/spec/integration/elastic_graph/schema_definition/rake_tasks_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/factory_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/indexing/json_schema_with_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_field_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_pruner_spec.rb elasticgraph-indexer/spec/unit/elastic_graph/indexer/record_preparer_spec.rb elasticgraph-apollo/spec/unit/elastic_graph/apollo/apollo_directives_spec.rb elasticgraph-apollo/spec/unit/elastic_graph/apollo/schema_definition_spec.rb
  • script/type_check
  • script/quick_build passes spellcheck, lint, type check, and schema artifact checks locally; it stops before the full spec run because the local Docker/test datastore is not running at http://localhost:9234.

@jwils jwils force-pushed the joshuaw/json-ingestion-schema-support branch from 7f5b7f1 to 1fbcfe5 Compare May 30, 2026 20:49
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-stack branch from e3dee45 to 595ca74 Compare May 30, 2026 20:49
@jwils jwils force-pushed the joshuaw/json-ingestion-schema-support branch from 1fbcfe5 to 9eabfa9 Compare May 31, 2026 05:24
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-stack branch from 595ca74 to 5801306 Compare May 31, 2026 05:24
@jwils jwils force-pushed the joshuaw/json-ingestion-schema-support branch from 9eabfa9 to ffec0c4 Compare May 31, 2026 11:26
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-stack branch from 5801306 to b253655 Compare May 31, 2026 11:26
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-stack branch from b253655 to 29fb38e Compare May 31, 2026 12:28
@jwils jwils closed this May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant