When loading artifacts check dumped elasticgraph version #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyosity
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch,
lancethomps,
myronmarston,
nicolewoch,
thomasmahoney and
zachbutler-squareup
as code owners
|
|
myronmarston
requested changes
Oct 15, 2025
Collaborator
myronmarston
left a comment
myronmarston
left a comment
There was a problem hiding this comment.
Great work @coreycullen00! Left a few suggestions.
elasticgraph-schema_artifacts/lib/elastic_graph/schema_artifacts/runtime_metadata/schema.rb
Outdated
Show resolved
Hide resolved
...ph-schema_artifacts/spec/unit/elastic_graph/schema_artifacts/runtime_metadata/schema_spec.rb
Outdated
Show resolved
Hide resolved
elasticgraph-schema_definition/lib/elastic_graph/schema_definition/results.rb
Show resolved
Hide resolved
Collaborator
myronmarston
left a comment
myronmarston
left a comment
There was a problem hiding this comment.
LGTM apart from some linting errors. Run this to fix this:
bundle exec standardrb --fix
...ph-schema_artifacts/spec/unit/elastic_graph/schema_artifacts/runtime_metadata/schema_spec.rb
Outdated
Show resolved
Hide resolved
...ph-schema_artifacts/spec/unit/elastic_graph/schema_artifacts/runtime_metadata/schema_spec.rb
Outdated
Show resolved
Hide resolved
myronmarston
approved these changes
Oct 20, 2025
myronmarston
added a commit
that referenced
this pull request
Jan 23, 2026
PR #874 added ElasticGraph version to runtime_metadata.yaml. Without regenerating artifacts during version bump, CI fails with version mismatch. Co-Authored-By: Claude <noreply@anthropic.com>
myronmarston
added a commit
that referenced
this pull request
Jan 24, 2026
PR #874 added ElasticGraph version to runtime_metadata.yaml. Without regenerating artifacts during version bump, CI fails with version mismatch. Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #765
Summary
This PR adds version tracking and validation to ElasticGraph's runtime metadata to ensure compatibility between the schema artifacts and the runtime version.
Changes
elasticgraph_versionfield to runtime metadata schema that captures the ElasticGraph version during schema artifact generation