fix: read_resource_tool deadlock causing test_compaction to hang

[lifeizhou-ap]

Summary

Why:
test_compaction smoke test hung infinitely, cancelled after 6 hours by GitHub Actions. This happened frequently now. https://github.com/block/goose/actions/workflows/pr-smoke-test.yml?query=is%3Acancelled

Root Cause:
The compact smoke test does not have developer extension enabled setup. Without developer extension, the LLM sometimes tried to use extensionmanager__read_resource to read a file (eg: read hello.txt). This caused a deadlock:

dispatch_tool_call("extensionmanager__read_resource")
└── Acquires LOCK on extensionmanager
└── read_resource_tool() iterates ALL extensions
└── Tries extensionmanager → needs same LOCK → 💀 DEADLOCK

The bug was intermittent due to HashMap's random iteration order - sometimes apps was checked first (works), sometimes extensionmanager was first (deadlock).

How to reproduce the problem

goose run --text "use the read_resource tool to read the resource with uri ui://apps/clock"

This does not guarantee the command always hangs (due to the order of extensions HashMap), but much more frequent than the compact smoke test.

Fix:
Only iterate extensions that actually support resources (matching existing list_resources() pattern)

Note
In current test_compaction.sh

(cd "$TESTDIR" && "$GOOSE_BIN" run --text "list files and read hello.txt" 2>&1) | tee "$OUTPUT"

We could change it later with something simpler without developer tool (eg: describe Melbourne AU in 100 words) as the test is mainly for compaction feature. However, I still leave the prompt as it is for now so that we can observe whether the problem is fixed.

Type of Change

• Feature
• Bug fix
• Refactor / Code quality
• Performance improvement
• Documentation
• Tests
• Security fix
• Build / Release
• Other (specify below)

AI Assistance

• This PR was created or reviewed with AI assistance

Testing

Manual testing with the command that reproduces the problem

[lifeizhou-ap]

At the moment, even with platform__read_resource in the system prompt , LLM is smart to call extensionmanager__read_resource tool. However, it is better to update with proper extension name.

[Copilot]

Pull request overview

This PR fixes a critical deadlock bug in the read_resource_tool method that caused the test_compaction smoke test to hang indefinitely. The deadlock occurred when the LLM tried to use extensionmanager__read_resource without specifying an extension name, causing the code to iterate through all extensions while holding a lock that was needed by the called methods.

Changes:

• Fixed deadlock in read_resource_tool by collecting extension names before iterating and filtering to only resource-capable extensions
• Corrected tool name documentation from incorrect platform__* to correct extensionmanager__* prefix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/goose/src/agents/extension_manager.rs	Fixed deadlock by filtering extensions to only those supporting resources and collecting names before iteration, matching the pattern used in list_resources()
crates/goose/src/prompts/system.md	Corrected tool names from platform__read_resource and platform__list_resources to extensionmanager__read_resource and extensionmanager__list_resources

[DOsinga]

thanks! nice work

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.