Docs: vision, architecture, status sweep; tag-driven release machinery - #2
Open
Kiran01bm wants to merge 6 commits into
Open
Docs: vision, architecture, status sweep; tag-driven release machinery#2Kiran01bm wants to merge 6 commits into
Kiran01bm wants to merge 6 commits into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
…aration MySQL lets authors assert the cost bracket (INSTANT/INPLACE/COPY) and the lock impact (NONE/SHARED/EXCLUSIVE) and fails closed; PostgreSQL has no such clause. State in the README, the planner package doc, and the online-DDL reference that the planner proves both dimensions before execution and routes to the safest sequence that exists.
Port the vision from the research doc set: pg-sprite as the go-to engine for all PostgreSQL schema changes — the reliable, deterministic execution layer under a GitOps front-end like SchemaBot, as Spirit is for MySQL. Five pillars, success criteria, and explicit non-goals.
Break the planner box into its pipeline: parse, introspect, diff, classify, lint — showing where the imperative and declarative front-ends enter and that both converge on the same classify -> lint tail. Add a per-stage table (package, input -> output, why it is a separate stage).
Mirrors the spirit/schemabot release approach: v* tag push builds linux/darwin amd64+arm64 archives with checksums via goreleaser and publishes a GitHub release. Pure-Go cross-compile (Wasm parser) verified for all three targets.
The design docs predate the execute-and-introspect decision and the Phase 2 landings; sweep every doc so implemented behavior reads as present, planned behavior is marked with its phase, and decided questions (in-house schemadiff, Wasm parser, CDC strategy) are no longer listed as open.
Disable setup-go caching (cache poisoning surface in an artifact-publishing job), repin goreleaser-action to the real v6.3.0 SHA (the previous pin was v6.1.0 mislabeled), and stop persisting checkout credentials.
Kiran01bm
changed the base branch from
main
to
kiran01bm/phase-2-3-2-4-classifier-router
August 5, 2026 08:56
Kiran01bm
marked this pull request as ready for review
August 5, 2026 23:25
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Top of the pg-sprite foundation stack: the vision and architecture docs, a status-accuracy sweep across the doc set, and tag-driven release machinery.
What
docs/vision.md(what pg-sprite is and is not) and the expanded architecture map with the five front-end stages.v*tags → linux/amd64, linux/arm64, darwin/arm64 archives,CGO_ENABLED=0), zizmor findings fixed (no setup-go cache in the publishing job, verified action pin, no persisted credentials).The stack
Foundation work lands as a reviewable stack, bottom-up (merge with merge commits, not squash, so children retarget cleanly):
kiran01bm/p0-foundations— Phase 0: scaffold, dbconn + Aurora TLS, doc baseline, OSS governancekiran01bm/ci-foundations— CI matrix (PG 14–18), hooks, test-methodology registry, lint enforcementkiran01bm/phase-1-front-door— Phase 1: optimistic migrate, typed verdicts, logging principleskiran01bm/phase-2-1-2-2-diff— Phase 2.1–2.2: parse boundary, execute-and-introspect declarative diff,diff/fmtkiran01bm/phase-2-3-2-4-classifier-router— Phase 2.3–2.4: descriptors, classifier, router seamWhat lands next (separate PRs)
CREATE INDEX CONCURRENTLYlifecycle, bounded lock retry, substitution/--force, progress.