fix(ui): remove non-functional CHANGE SEAT button from table

[bitcoinbrisbane]

Summary

Remove the "CHANGE SEAT" functionality from the UI. This feature is non-functional (no PVM/chain support) and adds visual clutter and confusion to the table. It should be removed now and re-implemented properly if/when the PVM supports seat changes.

What to Remove

The "CHANGE SEAT" button appears on vacant seats when the user is already seated at the table. It is wired through PlayerPopUpCard but does nothing useful — there is no chain action to move a player between seats.

Files to Modify

File	Change
ui/src/components/playPage/Players/VacantPlayer.tsx	Remove "CHANGE SEAT" popup/label for seated users — vacant seats should only show "SIT HERE" for unseated users
ui/src/components/playPage/Players/PlayerPopUpCard.tsx	May be removable entirely if only used for change seat (check OppositePlayer.tsx usage)
ui/src/components/playPage/Players/PlayerCard.tsx	Remove "CHANGE SEAT" label references
ui/src/components/playPage/Players/OppositePlayer.tsx	Check/remove any change seat popup integration
ui/src/components/playPage/Table/components/PlayerSeating.tsx	Check for change seat prop passing

Screenshot (current broken state)

Acceptance Criteria

• No "CHANGE SEAT" button visible anywhere in the UI
• Vacant seats only show "SIT HERE" for users who are not already seated
• Vacant seats show nothing (or just the empty seat visual) for users who are already seated
• PlayerPopUpCard removed if no longer needed, or cleaned up if used elsewhere
• yarn build passes, yarn lint:fix passes

Related

• block52/poker-vm#1299 — Change seat modal (closed — was styling only, feature never worked)
• feat(pvm): Complete sit-in / sit-out / leave table state logic (cash games) #51 — Sit-in/sit-out/leave table epic (active)

🤖 Generated with Claude Code

[bitcoinbrisbane]

Tech Debt Issue

The CHANGE SEAT button is currently displayed in the table UI but is non-functional. This creates user confusion and should be removed until the feature is properly implemented.

Current Problem

• Button appears in player controls or table interface
• Clicking the button does nothing or shows error
• No backend implementation to support seat changing
• Creates false expectation for users

Proposed Fix

Remove the CHANGE SEAT button from the UI until:

• Backend seat-changing logic is implemented
• Frontend can properly handle seat change requests
• Feature is fully tested and ready for production

Alternative Approach

If seat changing is planned soon:

• Disable the button (greyed out, no click handler)
• Add tooltip: Coming soon
• Keep UI structure for easier implementation later

Files to Update

Likely locations:

• ui/src/components/player/ - Player controls components
• ui/src/components/table/ - Table action buttons
• Search codebase for CHANGE SEAT or similar text

Related Work

This may be part of larger seating refactor:

• Coordinate with sit-in/sit-out logic (feat(pvm): Complete sit-in / sit-out / leave table state logic (cash games) #51)
• May need backend seat management API first
• Consider UX for seat selection process

Code Cleanup

When removing:

• Delete button component or conditional rendering
• Remove any associated event handlers
• Clean up unused imports or hooks
• Update tests if button was tested

Benefits of Removal

• Reduces user confusion
• Cleaner UI without non-functional elements
• Removes tech debt and dead code
• Can re-add properly when feature is ready

Priority: Low-Medium - UX clarity and code cleanup
Effort: Small - Simple removal or disabling of button