Chore/dev fixes#2060
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7df0bb80e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Add a changeset for Gateful logging behavior
When the version workflow consumes this PR, only the API package will be bumped: the PR also changes Gateful's request logging behavior in apps/gateful/src/middlewares/logger.ts by suppressing health logs and correcting thrown-error statuses, but no pending changeset names @anticapture/gateful. The repository's .claude/skills/changesets/SKILL.md requires every behavior-changing package to be selected, so these Gateful changes would receive neither a version bump nor a changelog entry; add a Gateful patch changeset.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Note
Medium Risk
The historical voting-power SQL change affects API pagination and delegation display for multi-delegation transactions; logging changes are low risk but touch all non-health API traffic in gateful.
Overview
Historical voting power is refactored so delegation/transfer enrichment no longer inflates result rows when a transaction has multiple delegations.
historical-query.tspaginates history first, then uses lateral subqueries with deterministic ordering (delegate vspreviousDelegate, log index) to attach a single related delegation and transfer per row. Integration tests cover redelegation (previousDelegate) andlimit=1with two delegations in the same tx.Observability: API entrypoints (
cmd/index.ts,cmd/aave.ts) and gatefulrequestLoggerskip access logging for/health(alongside/metrics). Gateful error logs now use a sharedgetErrorStatus(HTTP exceptions,CircuitOpenError→ 503) instead of relying onc.resduring failures; unit tests were added.Repo cleanup: Removes the git-tracked Claude shared auto-memory setup (
.agents/shared-memory,scripts/setup-memory.mjs,pnpm setup:memory) and an unused authful changeset; adds an@anticapture/apipatch changeset for the voting-power fix.Reviewed by Cursor Bugbot for commit b7df0bb. Configure here.