Skip to content

ci: slim test pipelines and colocate api specs - #173

Merged
gaboesquivel merged 2 commits into
mainfrom
ci/qa-e2e-follow-up
Sep 3, 2026
Merged

ci: slim test pipelines and colocate api specs#173
gaboesquivel merged 2 commits into
mainfrom
ci/qa-e2e-follow-up

Conversation

@gaboesquivel

Copy link
Copy Markdown
Member

Summary

  • Follow-up to ci: optimize test workflows and add vitest coverage #172: share Playwright spawn helpers, cache Chromium via .github/actions/setup-playwright, and wire optional Turbo remote cache on lint, packages-test, and web-e2e
  • Run package CI only for packages that define test (core, react, error); drop dummy echo "no test" scripts
  • Colocate API Vitest group entries next to their routes, fail test:unit on orphan *.test.ts imports, and run setup E2E after auth (passkey-login after setup)
  • pnpm qa skips install when node_modules exists, checks OpenAPI drift, then builds before E2E with SKIP_BUILD=1

Test plan

  • pnpm qa completes locally (checktypes, lint, OpenAPI drift, build, unit, e2e)
  • CI packages-test builds and tests only @repo/core, @repo/react, @repo/error
  • CI web-e2e uses setup-playwright and still requires ANTHROPIC_API_KEY for chat
  • API unit job fails if a new *.test.ts is not imported by a *.spec.ts
  • Web Playwright DAG: publicauthsetup{chromium, security, passkey-login}; chromiumchat

@gaboesquivel gaboesquivel added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 3, 2026
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
basilic-docs Canceled Canceled Sep 3, 2026 12:51am UTC
basilic-fastify Ready Ready Preview Sep 3, 2026 12:51am UTC
basilic-next Canceled Canceled Sep 3, 2026 12:51am UTC

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 41198825-7ca6-4c18-815d-d3bb54eb02a2

📥 Commits

Reviewing files that changed from the base of the PR and between ae4e696 and df34424.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/pnpm-lock.yaml
📒 Files selected for processing (77)
  • .cursor/rules/frontend/e2e-playwright.mdc
  • .github/actions/setup-playwright/action.yml
  • .github/workflows/lint.yml
  • .github/workflows/packages-test.yml
  • .github/workflows/web-e2e.yml
  • README.md
  • apps/api/package.json
  • apps/api/playwright.config.ts
  • apps/api/scripts/check-test-imports.mjs
  • apps/api/src/lib/ai/download.test.ts
  • apps/api/src/lib/ai/messages.spec.ts
  • apps/api/src/lib/ai/messages.test.ts
  • apps/api/src/lib/api-keys/api-keys.spec.ts
  • apps/api/src/lib/api-keys/keys.test.ts
  • apps/api/src/lib/passkey/origin.spec.ts
  • apps/api/src/lib/passkey/origin.test.ts
  • apps/api/src/lib/url.spec.ts
  • apps/api/src/lib/url.test.ts
  • apps/api/src/routes/auth/magiclink/magiclink.spec.ts
  • apps/api/src/routes/auth/magiclink/request.test.ts
  • apps/api/src/routes/auth/magiclink/verify.test.ts
  • apps/api/src/routes/auth/oauth.spec.ts
  • apps/api/src/routes/auth/oauth/facebook/authorize-url.test.ts
  • apps/api/src/routes/auth/oauth/facebook/exchange.test.ts
  • apps/api/src/routes/auth/oauth/facebook/link-authorize-url.test.ts
  • apps/api/src/routes/auth/oauth/github/authorize-url.test.ts
  • apps/api/src/routes/auth/oauth/github/exchange.test.ts
  • apps/api/src/routes/auth/oauth/github/link-authorize-url.test.ts
  • apps/api/src/routes/auth/oauth/google/authorize-url.test.ts
  • apps/api/src/routes/auth/oauth/google/exchange.test.ts
  • apps/api/src/routes/auth/oauth/google/link-authorize-url.test.ts
  • apps/api/src/routes/auth/oauth/google/verify-id-token.test.ts
  • apps/api/src/routes/auth/oauth/oauth.spec.ts
  • apps/api/src/routes/auth/oauth/providers.test.ts
  • apps/api/src/routes/auth/oauth/twitter/authorize-url.test.ts
  • apps/api/src/routes/auth/oauth/twitter/exchange.test.ts
  • apps/api/src/routes/auth/oauth/twitter/link-authorize-url.test.ts
  • apps/api/src/routes/auth/passkey/exchange.test.ts
  • apps/api/src/routes/auth/passkey/passkey.spec.ts
  • apps/api/src/routes/auth/passkey/resolve-user.test.ts
  • apps/api/src/routes/auth/passkey/start.test.ts
  • apps/api/src/routes/auth/passkey/verify.test.ts
  • apps/api/src/routes/auth/session/logout.test.ts
  • apps/api/src/routes/auth/session/refresh.test.ts
  • apps/api/src/routes/auth/session/session.spec.ts
  • apps/api/src/routes/auth/session/user.test.ts
  • apps/api/src/routes/auth/session/validate-tokens.test.ts
  • apps/api/src/routes/auth/web3.spec.ts
  • apps/api/src/routes/auth/web3/eip155/nonce.test.ts
  • apps/api/src/routes/auth/web3/eip155/verify.test.ts
  • apps/api/src/routes/auth/web3/exchange.test.ts
  • apps/api/src/routes/auth/web3/nonce.test.ts
  • apps/api/src/routes/auth/web3/solana/nonce.test.ts
  • apps/api/src/routes/auth/web3/solana/verify.test.ts
  • apps/api/src/routes/auth/web3/web3.spec.ts
  • apps/api/src/routes/health.spec.ts
  • apps/api/src/routes/reference/reference.spec.ts
  • apps/api/test/utils/db-setup.ts
  • apps/api/vitest.global-setup.ts
  • apps/api/vitest.setup.ts
  • apps/docu/content/docs/deployment/github-actions.mdx
  • apps/docu/content/docs/testing/e2e-testing.mdx
  • apps/docu/content/docs/testing/index.mdx
  • apps/web/e2e/04-update-tokens.spec.ts
  • apps/web/e2e/06-logout.spec.ts
  • apps/web/e2e/chat-assistant.spec.ts
  • apps/web/e2e/dashboard.spec.ts
  • apps/web/package.json
  • apps/web/playwright.config.ts
  • apps/web/scripts/run-e2e-local.mjs
  • package.json
  • packages/ui/package.json
  • packages/utils/package.json
  • scripts/README.md
  • scripts/e2e-local-shared.mjs
  • scripts/run-qa.mjs
  • turbo.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant