This repository was archived by the owner on Aug 31, 2019. It is now read-only.
Advanced JS Project - #53
Closed
KingAtoki wants to merge 4 commits into
Closed
Conversation
seanchen1991
left a comment
seanchen1991
left a comment
Contributor
There was a problem hiding this comment.
Nice job on this assignment! A few minor nitpicks. I would definitely encourage you to come back to this lab if you find yourself with some extra time between sprints and finish it up. These are all important foundation concepts.
| // Return the new array. | ||
| const newElements = []; | ||
| for (let i = 0; i < elements.length; i++) { | ||
| newElements.push(cb(elements[i], i, elements)); |
Contributor
There was a problem hiding this comment.
No need to pass the elements array here.
| // for a potential password that will be compared to the `password` property. | ||
| // Return true if the potential password matches the `password` property. Otherwise return false. | ||
| // Return true if the potential password matches the `password` property. Otherwise return false. | ||
| if (potentialPassword === this.password) { |
Contributor
There was a problem hiding this comment.
You can just one-line this with return potentialPassword === this.password;.
| this.username = options.username; | ||
| this.password = options.password; | ||
| this.checkPassword = (string) => { | ||
| if (string === this.password) { |
Contributor
There was a problem hiding this comment.
Same thing here, you can just do return string === this.password;.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.