Conversation
sperrye
reviewed
Oct 11, 2017
| const map = (elements, cb) => { | ||
| const newArray = []; | ||
| for (let i = 0; i < elements.length; i++) { | ||
| newArray.push(elements[i]); |
There was a problem hiding this comment.
Don't forget to pass the elements to your cb. Line 20.
sperrye
reviewed
Oct 11, 2017
|
|
||
| const last = (element, cb) => { | ||
| cb(element[foods.length-1]); | ||
| } |
There was a problem hiding this comment.
You'll need to pass in foods, or a place holder for the array like (arr), or foods will be undefined. If element is your placeholder, you'll want the index of element, not the index of foods.
sperrye
reviewed
Oct 13, 2017
| return { | ||
| increment() { return value += 1; }, | ||
| decrement() { return value -= 1; }, | ||
| }; |
There was a problem hiding this comment.
Another way to increment/decrement is to use the ++ and -- operators. Example: value++
sperrye
reviewed
Oct 13, 2017
| // http://underscorejs.org/#values | ||
| Object.keys(values).forEach((key) => { | ||
| return Object.keys(obj[key]); | ||
| }); |
There was a problem hiding this comment.
You may want to revise line 19 from Object.keys(values) to Object.keys(obj) as obj is the object you're passing in and want to iterate over with forEach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.