Mitchell Robles - JavaScript-I#313
Open
mitchellr92 wants to merge 4 commits into
Open
Conversation
John-Spraul
reviewed
Aug 21, 2018
John-Spraul
left a comment
John-Spraul
left a comment
There was a problem hiding this comment.
- Git stuff 🎉
- Completed Assignment
- Stretch Problem
Great Work! 👏
| let lastCar = 0; | ||
|
|
||
| for (let i = 0; i < inventory.length; i++) { | ||
| if (inventory[i] === inventory[inventory.length - 1]) { |
There was a problem hiding this comment.
could have done something like:
lastCar = inventory[inventory.length - 1];
console.log(lastCar.car_make, lastCar.car_model);
| if (inventory[i].car_make === "BMW") { | ||
| BMWAndAudi.push(inventory[i]); | ||
| } else if (inventory[i].car_make === "Audi") { | ||
| BMWAndAudi.push(inventory[i]); |
There was a problem hiding this comment.
Also could have used the || operator
| antonietta.multiplyNums = function multiplyNums(x, y) { | ||
| const sum = x * y; | ||
| return sum; | ||
| } |
There was a problem hiding this comment.
Also possible to define methods inside the objects themselves
|
|
||
| parent.child.grandchild.speak = function speak() { | ||
| return "Hello, my name is " + this.name + "!"; | ||
| } |
There was a problem hiding this comment.
great job including the stretch problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed all tasks and challenges as well as stretch goals.
@John-Spraul