Skip to content

Brian Ruff#195

Open
BrianARuff wants to merge 6 commits into
bloominstituteoftechnology:masterfrom
BrianARuff:master
Open

Brian Ruff#195
BrianARuff wants to merge 6 commits into
bloominstituteoftechnology:masterfrom
BrianARuff:master

Conversation

@BrianARuff

Copy link
Copy Markdown

No description provided.

@crypto-jones

Copy link
Copy Markdown

Your code is clean, easy to read, and all functions as expected. Great job! I love how you are committing multiple times and explicating what you did in the commit message. You clearly have a solid grasp of the content.

  1. One minor thing I noticed is in challenge 2 of closure.js. You would need to increment before and not after count if you want the accumulator to increment to one for the first invocation of the function.

  2. In array-methods.js, for challenge 2, to clean up the code, you could just do let allCaps = runners.map...... instead of initializing an empty array above.

Other than that, outstanding job on this assignment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants