Keiran Kozlowski#237
Open
gooseandmegander wants to merge 3 commits into
Open
Conversation
gooseandmegander
commented
Aug 8, 2018
gooseandmegander
left a comment
gooseandmegander
left a comment
Author
There was a problem hiding this comment.
Nice job, Keiran. I've left some comments for you to review.
| } | ||
|
|
||
| getLength(items, function (length) { | ||
| console.log(items.length); |
Author
There was a problem hiding this comment.
You're not actually using the parameter length in the function's block. It would be more appropriate to use console.log(length);
| let allCaps = []; | ||
| let firstNames = []; | ||
|
|
||
| runners.forEach(function (runner) { |
Author
There was a problem hiding this comment.
Do you think it is necessary to use both forEach and map? Why?
| // ==== Challenge 4: Use .reduce() ==== | ||
| // The donations need to be tallied up and reported for tax purposes. Add up all the donations into a ticketPriceTotal array and log the result | ||
| let ticketPriceTotal = []; | ||
| let prices = []; |
Author
There was a problem hiding this comment.
Why did you add the prices functionality in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating PR to make code review comments.