Denise Escobar JS 2 Progress#278
Open
DenEscobar wants to merge 4 commits into
Open
Conversation
clarakosi
reviewed
Aug 22, 2018
clarakosi
left a comment
clarakosi
left a comment
There was a problem hiding this comment.
Great job with the closures and array methods! I made a small note in the callback file about returning the variable.
Overall, great work Densie! 💯
| console.log(runnerinfo) | ||
|
|
||
| // Problem 3 | ||
| // Return how many shirts we will need in each size |
There was a problem hiding this comment.
Great problem and a very fun and unique solution! 👍
| let cont = false; | ||
| for (i = 0; i < list.length; i++) { | ||
| if (list[i] === item) { | ||
| cont = true |
There was a problem hiding this comment.
Don't forget to return cont at the end of this for loop.
| // ==== Challenge 1: Write your own closure ==== | ||
| // Write a simple closure of your own creation. Keep it simple! | ||
| const adding = (x, y) => { | ||
| let intro = `If you add ${x} and ${y} it will equal `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@clarakosi