LUIS MARTINEZ#58
Open
luiscmartinez wants to merge 12 commits into
Open
Conversation
added 12 commits
May 22, 2018 11:15
bdurb
reviewed
May 23, 2018
| // The event director needs to have all the runner's first names converted to uppercase because the director BECAME DRUNK WITH POWER. Convert each first name into all caps and log the result | ||
| let allCaps = []; | ||
| console.log(allCaps); | ||
| let allCaps = [] |
There was a problem hiding this comment.
Nice use of map here, alternatively you don't have to create a new array variable, but it is a viable solution. Good job!
bdurb
reviewed
May 23, 2018
|
|
||
| // Problem 2 The director is corrupt like most donation funded programs. create a function to find out how much of the donatons will the director keep. He wants his fair share to be 65% | ||
|
|
||
| let fairShare = runners.reduce((sum, money) => sum + money.donation * 0.65, 0) |
|
@luiscmartinez thank you for the PR. Good work today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.