Validate vendor callback urls, and rename the default-vendor api - #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes the Terraform provider needs before it can manage runtime vendors.
saveused to complete a barecallback_urlwith/api/runtime/connect. Anything that declares configuration then reads back a value it never wrote and cannot tell that from drift, so the server now validates the field and refuses a URL with no path. The completion moves into the settings form, where a typing affordance belongs./api/config/default-vendorbecomes/api/config/default-runtime-vendor, withDefaultVendorInputandSettingsView.default_vendorrenamed to match. Thesettingsrow key staysdefault_vendor— it is storage no client can observe, and moving it would need a migration whose failure mode is silently resetting every deployment's default.Spec:
docs/superpowers/specs/2026-08-08-terraform-runtime-vendors-design.md