Core: Autopilot manager: Add fallback for first available router in case of invalid preferred one #2933
Merged
joaoantoniocardoso merged 1 commit intobluerobotics:masterfrom Oct 8, 2024
Conversation
joaomariolago
force-pushed
the
fallback-in-loading-fail
branch
3 times, most recently
from
5dcff3c to
2341753
Compare
joaomariolago
requested review from
Williangalvani,
joaoantoniocardoso and
patrickelectric
joaoantoniocardoso
approved these changes
Oct 3, 2024
Member
joaoantoniocardoso
left a comment
joaoantoniocardoso
left a comment
There was a problem hiding this comment.
I missed this fallback when I was testing mavlink-server PR and went back to master without changing back to mavp2p, but now I'm not sure how to test it. The code seems fine to me.
Collaborator
Author
If want to test it, just go in file browser and edit the settings.json from autopilot manager in the configs, you can change proffered router to anything and see in the autopilot logs if it will fallback; |
patrickelectric
approved these changes
Oct 8, 2024
Member
|
@JoaoMario109 can you rebase ? |
* Make autopilot manager fallback to first avbailable router when unable to start current preferred router
joaomariolago
force-pushed
the
fallback-in-loading-fail
branch
from
2341753 to
92b5f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.