core: frontend: speedtest: InternetSpeedTest: Fix widget not showing

[patrickelectric]

Fix #3145

Summary by Sourcery

Bug Fixes:

• Fix the internet speed test widget not appearing when the internet connection is offline.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes the issue of the Internet speed test widget not displaying correctly by refactoring the condition used to check for an offline internet state. Instead of directly checking the value of 'helper.has_internet' in the template, a new computed property 'internet_offline' has been introduced to encapsulate this logic. Additionally, the import statement was updated to import the 'InternetConnectionState' constant, providing better clarity and maintainability.

Updated class diagram for InternetSpeedTest component (Vue)

classDiagram
    class InternetSpeedTest {
      +mounted() async
      +latency_ms: number
      +internet_offline: boolean
    }

    %% Computed property internet_offline encapsulates the logic:
    %% internet_offline() returns (helper.has_internet === InternetConnectionState.OFFLINE)

Loading

File-Level Changes

Change	Details	Files
Refactored the condition for displaying the offline overlay.	Updated the v-overlay 'value' binding to use the new computed property 'internet_offline'. Introduced a computed property 'internet_offline' that returns a boolean based on comparing 'helper.has_internet' with 'InternetConnectionState.OFFLINE'.	core/frontend/src/components/speedtest/InternetSpeedTest.vue
Enhanced import statements for clarity.	Modified the import statement to include 'InternetConnectionState' alongside 'SpeedTestResult'.	core/frontend/src/components/speedtest/InternetSpeedTest.vue

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#3145	Resolve the issue of the internet speed test page being empty	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @patrickelectric - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the overlay into a separate component to improve readability.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}