PwmSetup:: add servoToHighlight function and map for handling newer ardusub version functions in highlighting#3156
Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom Feb 19, 2025
Conversation
Reviewer's Guide by SourceryThis pull request introduces a No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @Williangalvani - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why
Mount1Pitchneeds to be mapped toMountTilt.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…rdusub version functions in highlighting
6aee255 to
55fbe3b
Compare
patrickelectric
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mount not highlighting in pwm setup view
Summary by Sourcery
Improves the PWM setup view by ensuring the mount is highlighted and adding compatibility for newer ArduSub versions. This is achieved by introducing a
servoToHighlightfunction and a mapping for handling function name differences.Bug Fixes:
Enhancements: