Skip to content

Core: Frontend: ExtensionDetailsModal: Improve colors feedback for user#3216

Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom
joaomariolago:improve-ext-details-card-versions
Mar 20, 2025
Merged

Core: Frontend: ExtensionDetailsModal: Improve colors feedback for user#3216
patrickelectric merged 1 commit intobluerobotics:masterfrom
joaomariolago:improve-ext-details-card-versions

Conversation

@joaomariolago
Copy link
Collaborator

@joaomariolago joaomariolago commented Mar 20, 2025

  • When user have current installed version make the uninstall button red to differentiate from the primary install color.

image

  • When user opens the version drop down shows current installed version using (Active) marker and success-darken1 color.

image

Summary by Sourcery

Improves the Extension Details Modal by providing better color feedback to the user. It differentiates the uninstall button from the install button by changing its color to red when the extension is installed. It also indicates the currently installed version in the version dropdown with an '(Active)' marker and a success color.

Enhancements:

  • Improves color feedback in the Extension Details Modal.
  • Indicates the currently installed version in the version dropdown with an '(Active)' marker and a success color.
  • Changes the uninstall button color to red when the extension is installed to differentiate it from the install button.

* Make uninstall button have a red color
* Add `(Active)` marking to installed version and make it use success
  color
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 20, 2025

Reviewer's Guide by Sourcery

This pull request enhances the ExtensionDetailsModal component by improving color feedback for users. It differentiates the uninstall button color when the current version is installed and highlights the active version in the version dropdown.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the appearance of the uninstall button to improve visual feedback for users with the current version installed.
  • Changed the color of the uninstall button to red when the current version is installed.
core/frontend/src/components/kraken/modals/ExtensionDetailsModal.vue
Enhanced the version dropdown to indicate the currently installed version with a visual marker and color.
  • Added an '(Active)' marker to the currently installed version in the dropdown.
  • Applied a success-darken1 color to the active version in the dropdown.
core/frontend/src/components/kraken/modals/ExtensionDetailsModal.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joaomariolago - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more semantic class name instead of directly applying styles in the template.
  • It might be better to use a more descriptive variable name than item.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit e81de1d into bluerobotics:master Mar 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments