Core: Frontend: ExtensionDetailsModal: Improve colors feedback for user#3216
Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom Mar 20, 2025
Conversation
* Make uninstall button have a red color * Add `(Active)` marking to installed version and make it use success color
Reviewer's Guide by SourceryThis pull request enhances the ExtensionDetailsModal component by improving color feedback for users. It differentiates the uninstall button color when the current version is installed and highlights the active version in the version dropdown. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @joaomariolago - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more semantic class name instead of directly applying styles in the template.
- It might be better to use a more descriptive variable name than
item.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
patrickelectric
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Active)marker and success-darken1 color.Summary by Sourcery
Improves the Extension Details Modal by providing better color feedback to the user. It differentiates the uninstall button from the install button by changing its color to red when the extension is installed. It also indicates the currently installed version in the version dropdown with an '(Active)' marker and a success color.
Enhancements: