frontend: update axios version#3605
Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom Oct 20, 2025
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgraded axios to v1.x by replacing the deprecated CancelToken API with AbortController/AbortSignal, updating progress event handling to the new event shape, and bumping the dependency version. Class diagram for updated log and deletion controllersclassDiagram
class ExtensionManagerView {
- log_abort_controller: AbortController | null
+ showLogs(extension: InstalledExtensionData)
}
class SettingsMenu {
- deletion_log_abort_controller: AbortController | null
+ remove_service_log_files(): Promise<void>
}
ExtensionManagerView --> "1" AbortController
SettingsMenu --> "1" AbortController
Class diagram for updated getContainerLogs function signatureclassDiagram
class KrakenManager {
+ getContainerLogs(containerName: string, progressHandler: (event: any) => void, cancelToken: AbortSignal | undefined): Promise<any>
}
KrakenManager --> "1" AbortSignal
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider abstracting the repetitive
progressEvent.eventextraction into a small helper or axios interceptor so your download/log handlers can work directly with raw events and improve readability. - You may want to centralize AbortController setup and teardown (e.g. via a shared mixin or composable) to ensure consistent cancellation logic and avoid boilerplate across multiple components.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider abstracting the repetitive `progressEvent.event` extraction into a small helper or axios interceptor so your download/log handlers can work directly with raw events and improve readability.
- You may want to centralize AbortController setup and teardown (e.g. via a shared mixin or composable) to ensure consistent cancellation logic and avoid boilerplate across multiple components.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
patrickelectric
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #2605
The major change is that
CancelTokenSourcewas deprecated.Tested:
Summary by Sourcery
Upgrade axios to version 1.12.2, migrate from deprecated CancelToken API to AbortController, and adjust progress event handling across frontend components to ensure compatibility.
Enhancements: