core: frontend: wizard: rover/BOAT exists but no boat/UNDEFINED

[patrickelectric]

Fix #3678

src/assets/3d/generic_sensor.glb
src/assets/3d/navigator.glb
public/assets/vehicles/models/sub/SIMPLEROV_4.glb
public/assets/vehicles/models/sub/bluerov.glb
public/assets/vehicles/models/sub/CUSTOM.glb
public/assets/vehicles/models/sub/SIMPLEROV_3.glb
public/assets/vehicles/models/sub/SIMPLEROV_5.glb
public/assets/vehicles/models/sub/VECTORED.glb
public/assets/vehicles/models/sub/VECTORED_6DOF.glb
public/assets/vehicles/models/sub/BLUEROV1.glb
public/assets/vehicles/models/rover/BOAT.glb
public/assets/vehicles/models/rover/unknown.glb

Summary by Sourcery

Bug Fixes:

• Resolve incorrect default model configuration in the wizard by referencing rover BOAT instead of an undefined boat model.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the wizard component to initialize the boat_model using the correct rover/BOAT model instead of the previous boat/UNDEFINED model, aligning the frontend with the expected configuration semantics for boats in the wizard flow.

Class diagram for updated Wizard Vue component data initialization

classDiagram
  class WizardComponent {
    +boat_model any
    +scripts string[]
    +configuration_failed boolean
    +error_message string
    +data()
  }

  class ModelFactory {
    +get_model(category string, name string) any
  }

  WizardComponent ..> ModelFactory : uses get_model

  %% Updated initialization:
  %% boat_model = get_model(rover, BOAT) instead of get_model(boat, UNDEFINED)

Loading

File-Level Changes

Change	Details	Files
Initialize boat_model with the correct rover/BOAT model in the wizard component.	Replace the get_model call used to initialize boat_model with one that requests the rover domain and BOAT model key instead of the boat domain and UNDEFINED model key Ensure the default boat_model aligns with the expected configuration used elsewhere in the wizard logic	core/frontend/src/components/wizard/Wizard.vue

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#3678	Ensure the wizard correctly loads and displays the boat model instead of failing to show it.	✅

Possibly linked issues

• wizard is not showing boat model #3678: The PR changes boat_model resolution in the wizard, directly addressing the issue where the boat model is not shown.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Now that boat_model is initialized from get_model('rover', 'BOAT'), consider renaming the variable to better reflect that it holds a rover/BOAT model to avoid future confusion.
• If other parts of the wizard still expect a boat type rather than rover, double-check that this change doesn't introduce mismatches in downstream use of boat_model (e.g., in conditionals or templates) and align naming/type expectations accordingly.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that `boat_model` is initialized from `get_model('rover', 'BOAT')`, consider renaming the variable to better reflect that it holds a rover/BOAT model to avoid future confusion.
- If other parts of the wizard still expect a `boat` type rather than `rover`, double-check that this change doesn't introduce mismatches in downstream use of `boat_model` (e.g., in conditionals or templates) and align naming/type expectations accordingly.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}