-
Notifications
You must be signed in to change notification settings - Fork 119
Upload releases to S3 #3685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload releases to S3 #3685
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR extends the existing GitHub Actions release workflow to authenticate with AWS and upload built Raspberry Pi release ZIPs to an S3 bucket when a tag build runs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The
aws s3 synccommand is being used with a single ZIP file path rather than a directory; consider usingaws s3 cpfor uploading a single artifact to avoid unexpected behavior. - Using
--deletewhen syncing to theblueos-downloadsbucket can remove unrelated existing objects; consider targeting a dedicated prefix for these artifacts or omitting--deleteto avoid accidental deletions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `aws s3 sync` command is being used with a single ZIP file path rather than a directory; consider using `aws s3 cp` for uploading a single artifact to avoid unexpected behavior.
- Using `--delete` when syncing to the `blueos-downloads` bucket can remove unrelated existing objects; consider targeting a dedicated prefix for these artifacts or omitting `--delete` to avoid accidental deletions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
f0923f7 to
2425fa4
Compare
voorloopnul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking ok, should work!
Summary by Sourcery
Upload release artifacts to S3 during tagged builds.
CI: