Skip to content

core: tools: nginx: Add a 404 if extension is not registered#3905

Merged
Williangalvani merged 1 commit intobluerobotics:masterfrom
patrickelectric:nginx-extensionv2-404
Apr 28, 2026
Merged

core: tools: nginx: Add a 404 if extension is not registered#3905
Williangalvani merged 1 commit intobluerobotics:masterfrom
patrickelectric:nginx-extensionv2-404

Conversation

@patrickelectric
Copy link
Copy Markdown
Member

@patrickelectric patrickelectric commented Apr 28, 2026

Fix #3904

Summary by Sourcery

Bug Fixes:

  • Ensure unknown /extensionv2/ routes return a 404 error rather than being handled by the single-page application.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The error_page 404 = @extension_not_found; directive in the /extensionv2/ location is never used because the return 404; immediately exits; either remove the error_page/named location or move the JSON response directly into the main location block.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `error_page 404 = @extension_not_found;` directive in the `/extensionv2/` location is never used because the `return 404;` immediately exits; either remove the `error_page`/named location or move the JSON response directly into the main location block.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric
Copy link
Copy Markdown
Member Author

Tested and working:
image

Copy link
Copy Markdown
Member

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Williangalvani Williangalvani merged commit 62d018e into bluerobotics:master Apr 28, 2026
7 checks passed
@rafaellehmkuhl
Copy link
Copy Markdown
Member

@patrickelectric I believe this PR is a good defensive measure, but it doesn't fulfill the needs of #3904?

@rafaellehmkuhl
Copy link
Copy Markdown
Member

@patrickelectric I believe this PR is a good defensive measure, but it doesn't fulfill the needs of #3904?

Just tested and it actually does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlueOS should make it clear for external sources when accessing an extension page that is not ready

3 participants