[1.4 backport] Frontend: fix SERVOn_TRIM parameter editor being grayed out

[Williangalvani]

Backport of #3954

Summary by Sourcery

Bug Fixes:

• Correct the disabled state of the servo trim parameter editor card to depend on the resolved trim parameter name instead of the raw trim parameter reference.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Automated PR Review

0. Summary

• Verdict: MINOR SUGGESTIONS ✏️

Two-line fix in core/frontend/src/components/parameter-editor/ServoFunctionRangeEditor.vue: gates the trim parameter card's disabled/disabled-card state on resolvedTrimParam?.name instead of the raw trimParam prop. Since resolvedTrimParam falls back to autopilot.parameter(<name>_TRIM) when the trimParam prop isn't passed, the card was previously grayed out whenever the parent didn't explicitly forward the trim parameter — exactly the SERVOn_TRIM scenario the PR title describes. The change matches the surrounding code (label/param on lines 86-87 already use resolvedTrimParam), so this is a coherent fix.

1. Correctness & Implementation Bugs

• 1.1 [minor] core/frontend/src/components/parameter-editor/ServoFunctionRangeEditor.vue:40 — the slider's trim thumb is still gated on the raw trimParam prop (v-show="thumbType !== 'trim' || trimParam"), while the rest of the component (findClosestThumb, updateValueBasedOnThumb, updateMin/updateMax constraint logic) now uses resolvedTrimParam. By the same logic as this PR, the trim thumb will be hidden in the SERVOn_TRIM case where trimParam isn't forwarded but resolvedTrimParam resolves successfully — leaving the card editable but the slider thumb missing. Worth switching this to resolvedTrimParam in the same backport for consistency.

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

[joaoantoniocardoso]

tested 🥇