Change title for v-tooltip#3960
Merged
patrickelectric merged 4 commits intoJun 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Some of the new
v-tooltipusages wrap static strings in template literals (e.g.v-tooltip="`MAVLink heartbeat lost`"); consider using plain string bindings for these to keep the template a bit cleaner and more consistent (e.g.v-tooltip="'MAVLink heartbeat lost'"). - For the interpolated tooltip strings, you can simplify the syntax by dropping the
:prefix style you previously used withtitleand just rely onv-tooltipbeing an expression binding (e.g.v-tooltip="heartbeat_message()"is fine, but make sure this is consistent across all similar uses).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Some of the new `v-tooltip` usages wrap static strings in template literals (e.g. ``v-tooltip="`MAVLink heartbeat lost`"``); consider using plain string bindings for these to keep the template a bit cleaner and more consistent (e.g. `v-tooltip="'MAVLink heartbeat lost'"`).
- For the interpolated tooltip strings, you can simplify the syntax by dropping the `:` prefix style you previously used with `title` and just rely on `v-tooltip` being an expression binding (e.g. `v-tooltip="heartbeat_message()"` is fine, but make sure this is consistent across all similar uses).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
Hi @rafael-graunke, thanks for the contribution. Take a look in the CI to check for linter errors: https://github.com/bluerobotics/BlueOS/actions/runs/27802800284/job/82350381393?pr=3960 |
15b96f9 to
a139744
Compare
patrickelectric
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3935
Replaces
titleattributes with thev-tooltipdirective in four tray menu components:InternetTrayMenuThemeTrayMenuGpsTrayMenuHealthTrayMenuThis makes tooltips consistent with the rest of the codebase.
Tested locally.
Summary by Sourcery
Enhancements: