Skip to content

Change title for v-tooltip#3960

Merged
patrickelectric merged 4 commits into
bluerobotics:masterfrom
rafael-graunke:fix/change-title-for-tooltip
Jun 19, 2026
Merged

Change title for v-tooltip#3960
patrickelectric merged 4 commits into
bluerobotics:masterfrom
rafael-graunke:fix/change-title-for-tooltip

Conversation

@rafael-graunke

@rafael-graunke rafael-graunke commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Closes #3935

Replaces title attributes with the v-tooltip directive in four tray menu components:

  • InternetTrayMenu
  • ThemeTrayMenu
  • GpsTrayMenu
  • HealthTrayMenu

This makes tooltips consistent with the rest of the codebase.

Tested locally.

Summary by Sourcery

Enhancements:

  • Standardize tooltip usage in Internet, Theme, GPS, and Health tray menus by switching from title attributes to the v-tooltip directive.

@CLAassistant

CLAassistant commented Jun 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Some of the new v-tooltip usages wrap static strings in template literals (e.g. v-tooltip="`MAVLink heartbeat lost`"); consider using plain string bindings for these to keep the template a bit cleaner and more consistent (e.g. v-tooltip="'MAVLink heartbeat lost'").
  • For the interpolated tooltip strings, you can simplify the syntax by dropping the : prefix style you previously used with title and just rely on v-tooltip being an expression binding (e.g. v-tooltip="heartbeat_message()" is fine, but make sure this is consistent across all similar uses).
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Some of the new `v-tooltip` usages wrap static strings in template literals (e.g. ``v-tooltip="`MAVLink heartbeat lost`"``); consider using plain string bindings for these to keep the template a bit cleaner and more consistent (e.g. `v-tooltip="'MAVLink heartbeat lost'"`).
- For the interpolated tooltip strings, you can simplify the syntax by dropping the `:` prefix style you previously used with `title` and just rely on `v-tooltip` being an expression binding (e.g. `v-tooltip="heartbeat_message()"` is fine, but make sure this is consistent across all similar uses).

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric

Copy link
Copy Markdown
Member

Hi @rafael-graunke, thanks for the contribution. Take a look in the CI to check for linter errors: https://github.com/bluerobotics/BlueOS/actions/runs/27802800284/job/82350381393?pr=3960

@rafael-graunke rafael-graunke force-pushed the fix/change-title-for-tooltip branch from 15b96f9 to a139744 Compare June 19, 2026 14:25
@patrickelectric patrickelectric merged commit e5249a2 into bluerobotics:master Jun 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tray icons should use proper tooltips instead of the :title: attribute

3 participants