Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more localizable #3962

Merged
merged 8 commits into from
May 15, 2024
Merged

Conversation

quiple
Copy link
Contributor

@quiple quiple commented May 11, 2024

- Toast.show(_(msg`${pinned ? 'Pinned to' : 'Unpinned from'} your feeds`))
+ Toast.show(
+   pinned
+     ? _(msg`Pinned to your feeds`)
+     : _(msg`Unpinned from your feeds`),
+ )

Enables localization of these strings.


스크린샷 2024-05-11 15 10 26

This part

Before:

#: src/screens/Feeds/NoFollowingFeed.tsx:38
msgid "Looks like you're missing a following feed."
msgstr ""

#: src/screens/Feeds/NoFollowingFeed.tsx:46
msgid "Click here to add one."
msgstr ""

After:

#: src/screens/Feeds/NoFollowingFeed.tsx:37
msgid "Looks like you're missing a following feed. <0>Click here to add one.</0>"
msgstr ""

Makes it easier to understand the context of a string. It's also better suited for localization in languages that don't use whitespace.

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haileyok haileyok merged commit 2121b5f into bluesky-social:main May 15, 2024
6 checks passed
tkusano added a commit to tkusano/social-app that referenced this pull request May 15, 2024
@quiple quiple deleted the make-more-localizable branch May 15, 2024 06:55
estrattonbailey added a commit that referenced this pull request May 15, 2024
* origin/main: (48 commits)
  [🐴] Show if user can be messaged in new chat search (#4021)
  Make more localizable (#3962)
  [🐴] change `Follows Only` to `People I Follow` (#4028)
  Reset after 5 min (#4026)
  [🐴] Block states, read only (#4022)
  [🐴]Add DM push notification sound (#4000)
  remove serviceurl gate (#4019)
  reword subtitle (#4017)
  [🐴] show deleted account for `missing.invalid` (#4014)
  [🐴] use "Chats" instead of "Messages" (#4013)
  100vh settings screen (#4015)
  Run intl extract (#4016)
  [🐴] Settings screen (#3830)
  [🐴] Message drafts (#3993)
  Update Korean localization (#3887)
  Update catalan messages.po (#3984)
  Fix dep (#4011)
  [🐴] Make status checks easier, fix load state (#4010)
  [🐴] Chat muted state (#3988)
  [🐴] Swap in new package, update usages (#3992)
  ...
pfrazee pushed a commit that referenced this pull request May 20, 2024
* Update Japanese translations

* Updated as PR on Plural is merged (#3882)
* Feedback API (#3498)

etc.

* Improve localization marks (#3285)

* Update Lightbox.tsx

* Change strings for easier localization

* Update DeleteAccount.tsx

* Update LabelsOnMeDialog.tsx

* Update FeedCard.tsx

* Update index.tsx

* Update LabelsOnMeDialog.tsx

* Update index.tsx

* Update FeedCard.tsx

* Update SelfLabel.tsx

* Update Hashtag.tsx

* Update index.tsx

* Update Hashtag.tsx

* Update ChangeHandle.tsx

* Update index.web.tsx

* Update index.web.tsx

* Update index.tsx

* Remove unnecessary `<Trans>` tags

* Update Drawer.tsx

* Finnish translation update (#3755)

* Update messages.po

Translated new strings (GIF's etc) and cleaned up deprecated ones.

* Update messages.po

resolve conflict

* Update messages.po

removed double quotes. Thanks @lapanti

* fix bad bool check in action (#3885)

* fix bad bool check in action

* add `fetch-depth` so we can get the commit hash

* `.env` should be in `.easignore` 🙃

* Updated to follow #3285 etc.

* The translation of 'place' and 'apply' of labels has been unified into '適用する'.

* Fix translation of "repost"

* Updated

* Updated Japanese translation

* Updated Japanese translation

- #3816

* Fixed translations

* Updated translation : #3995

* Updated Japanese translation

* Updated Japanese translation (ref. #3962 #4028)

* Updated Japanese translation

* Updated Japanese translation

* Updated Japanese translation

---------

Co-authored-by: Minseo Lee <itoupluk427@gmail.com>
Co-authored-by: Jan-Olof Eriksson <jan-olof.eriksson@iki.fi>
Co-authored-by: Hailey <me@haileyok.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants