[🐴] show deleted account for missing.invalid
#4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
haileyok
commented
May 14, 2024
•
haileyok
commented
|
Your Render PR Server URL is https://social-app-pr-4014.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp1qgpicn0vc73c3gvng. |
|
mozzius
requested changes
May 14, 2024
Comment on lines
36
to
38
| const displayName = isDeletedAccount | ||
| ? 'Deleted Account' | ||
| : otherUser?.displayName ?? otherUser?.handle |
There was a problem hiding this comment.
Should be
const displayName = isDeletedAccount
? 'Deleted Account'
: otherUser?.displayName || otherUser?.handleThere was a problem hiding this comment.
How do you get it to do the "accept suggested changes" button?
estrattonbailey
added a commit
that referenced
this pull request
May 15, 2024
* origin/main: (48 commits) [🐴] Show if user can be messaged in new chat search (#4021) Make more localizable (#3962) [🐴] change `Follows Only` to `People I Follow` (#4028) Reset after 5 min (#4026) [🐴] Block states, read only (#4022) [🐴]Add DM push notification sound (#4000) remove serviceurl gate (#4019) reword subtitle (#4017) [🐴] show deleted account for `missing.invalid` (#4014) [🐴] use "Chats" instead of "Messages" (#4013) 100vh settings screen (#4015) Run intl extract (#4016) [🐴] Settings screen (#3830) [🐴] Message drafts (#3993) Update Korean localization (#3887) Update catalan messages.po (#3984) Fix dep (#4011) [🐴] Make status checks easier, fix load state (#4010) [🐴] Chat muted state (#3988) [🐴] Swap in new package, update usages (#3992) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.