Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privileged app passwords #4200

Merged
merged 7 commits into from
May 23, 2024
Merged

Privileged app passwords #4200

merged 7 commits into from
May 23, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented May 23, 2024

Don't merge yet, awaiting backend + new @atproto/api release

image

image

Copy link

render bot commented May 23, 2024

@mozzius mozzius marked this pull request as draft May 23, 2024 18:34
Copy link

github-actions bot commented May 23, 2024

Old size New size Diff
7.3 MB 7.3 MB 1007 B (0.01%)

Copy link

github-actions bot commented May 23, 2024

The Pull Request introduced fingerprint changes against the base commit: 9096655

Fingerprint diff
[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"134e65a5ea2526b82b8c1fe41fa59dfadb43855f"}]

Generated by PR labeler 🤖

@haileyok haileyok marked this pull request as ready for review May 23, 2024 22:59
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Modal padding needed a fix, got that in.

Overall for these PWs:

  • Tested a bsky account against skeetdeck
    • Non-privileged did not work
    • Privileged worked
  • Tested my own PDS after updating with the same results as above.

@haileyok haileyok merged commit d2c42cf into main May 23, 2024
6 checks passed
@haileyok haileyok deleted the samuel/privileged-app-pwd branch May 23, 2024 23:10
haileyok pushed a commit that referenced this pull request May 23, 2024
* add checkbox to create privileged app password

* add indicator to privileged app pwds to list

* bump api

* oops missed the yarnlock

* adjust modal padding

* lowercase

* one more lowercase

---------

Co-authored-by: Hailey <me@haileyok.com>
(cherry picked from commit d2c42cf)
estrattonbailey added a commit that referenced this pull request May 28, 2024
* origin/main: (392 commits)
  Remove old onboarding (#4224)
  Replace getAgent() with reading agent (#4243)
  Bump 1.85.0 (#4237)
  bump iOS target to `14.0` (#4238)
  set `onEndReachedThreshold` to `2` for notifications (#4235)
  Run intl extract (#4217)
  Updated Japanese translation (#4144)
  Updated Chinese translation (#4147)
  Update Korean localization (#4148)
  Update catalan messages.po (#4149)
  Update Indonesian translation (#4165)
  [🐴] update convo list from message bus (#4189)
  Recover from initial failed firehose state (#4211)
  Move ALT indicator right and shrink it a bit (#4213)
  Make sure failed messages enter error state (#4210)
  [🐴] Don't submit the message on return press when on a phone (web input) (#4203)
  Include feedContext in DOM as data- (#4206)
  Improve moderation behaviors: show alert/inform sources and improve UX around threads (#3677)
  Privileged app passwords (#4200)
  [🐴] Overfetch follow for default new dialog state (#4205)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants