Replace getAgent() with reading agent #4243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the session refactor, we have a guarantee that the
agent
within the tree is always the same instance. Let's take advantage of that guarantee and make it clearer in the code by removing thegetAgent
indirection.Before:
After:
## Test Plan
See
session/index.tsx
, notice that there's no actual change in semantics. The value was already being captured in a closure.Then read through the code. Most of this is simple find-and-replace, with some manual edits to fix types. I relied on types to fix the rest.
Do some basic things in the app, switch accounts, verify that still works.