[🐴] Overfetch follow for default new dialog state #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4205.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp7sbmkf7o1s739tle40. |
|
haileyok
approved these changes
May 23, 2024
haileyok
pushed a commit
that referenced
this pull request
May 23, 2024
(cherry picked from commit 406993c)
estrattonbailey
added a commit
that referenced
this pull request
May 28, 2024
* origin/main: (392 commits) Remove old onboarding (#4224) Replace getAgent() with reading agent (#4243) Bump 1.85.0 (#4237) bump iOS target to `14.0` (#4238) set `onEndReachedThreshold` to `2` for notifications (#4235) Run intl extract (#4217) Updated Japanese translation (#4144) Updated Chinese translation (#4147) Update Korean localization (#4148) Update catalan messages.po (#4149) Update Indonesian translation (#4165) [🐴] update convo list from message bus (#4189) Recover from initial failed firehose state (#4211) Move ALT indicator right and shrink it a bit (#4213) Make sure failed messages enter error state (#4210) [🐴] Don't submit the message on return press when on a phone (web input) (#4203) Include feedContext in DOM as data- (#4206) Improve moderation behaviors: show alert/inform sources and improve UX around threads (#3677) Privileged app passwords (#4200) [🐴] Overfetch follow for default new dialog state (#4205) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok last thing I had on my list to get in was related to the new chat dialog. Users are confused that they can’t message the users in the list.
The easiest way to help that right now is to overfetch follows and apply the same sorting, so that presumably a greater # of users can be messaged.
Right now we’re fetching 12, which for me rn returns only 6 I can follow. If I increase that to the default of 50, I get ~15, which is more than enough to fill the window.