-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Chinese translation #4147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge zh-CN latest translation
@cirx1e please help me review |
auroursa
commented
May 21, 2024
cirx1e
reviewed
May 22, 2024
Co-Authored-By: cirx <133132480+cirx1e@users.noreply.github.com>
pfrazee
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks yall!!
estrattonbailey
added a commit
that referenced
this pull request
May 28, 2024
* origin/main: (392 commits) Remove old onboarding (#4224) Replace getAgent() with reading agent (#4243) Bump 1.85.0 (#4237) bump iOS target to `14.0` (#4238) set `onEndReachedThreshold` to `2` for notifications (#4235) Run intl extract (#4217) Updated Japanese translation (#4144) Updated Chinese translation (#4147) Update Korean localization (#4148) Update catalan messages.po (#4149) Update Indonesian translation (#4165) [🐴] update convo list from message bus (#4189) Recover from initial failed firehose state (#4211) Move ALT indicator right and shrink it a bit (#4213) Make sure failed messages enter error state (#4210) [🐴] Don't submit the message on return press when on a phone (web input) (#4203) Include feedContext in DOM as data- (#4206) Improve moderation behaviors: show alert/inform sources and improve UX around threads (#3677) Privileged app passwords (#4200) [🐴] Overfetch follow for default new dialog state (#4205) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to merge zh-CN and zh-TW submissions in this PR.
For sure, reviewers can still review the language they are familiar with (zh-CN or zh-TW) separately. But if a reviewer finds a translation in zh-TW that can be improved, there is often a similar issue in zh-CN. In this way, both can be fixed together, which might help reduce the effort required to handle the merge.