Skip to content

Update bluesky-httpserver from changes in Tiled #86

Description

@davidpcls

Tiled has seen a large number of changes from when it and the bluesky-httpserver began diverging. There exists an opportunity to update bluesky-httpserver so that we can break out chunks of both Tiled and bluesky-httpserver into common packages which would reduce the maintenance requirements of each.

As I have been working on auth, the authentication flows have been my main focus, which is one area we can look to reduce duplication.

#81 attempts to update the authentication with minimal changes to bluesky-httpserver.

In that PR @danielballan mentioned that there have been updates to Tiled since I started this effort. This will continue to be an issue where we need to update bluesky-httpserver with changes from Tiled, which at the moment has the larger development team.

Ideally we could pull out the authentication in bluesky-httpserver and in tiled into a separate repository called bluesky-authentication, which would provide:

  1. Authentication code
  2. Authentication routes
  3. Authentication database
  4. (optional) authorization code (policies in bluesky-httpserver)

At the moment, bluesky-authentication cannot include the database and requires adapters, as the databases have diverged. One is async and the other is not.

I'd like to have a common auth repo, but that requires significant delay to actually having OIDC authenticators which affect those waiting for this feature.

So in the interest of time I am planning on doing the following steps:

  1. Update authenticators to those from Tiled (Updating authenticators from latest in Tiled #81)
  2. Update the database to match Tiled, along with routes and other useful functionality (Tiled and Bluesky-httpserver auth databases have diverged #85)
  3. Update https://github.com/davidpcls/bluesky-authentication so that it represents a clean and logical package
  4. Update Tiled to use Bluesky-authentication
  5. Udpate bluesky-httpserver to use bluesky-authentication

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions