manager: fix update dialog being re-opened on every recomposition - #1526
Merged
Merged
Conversation
The trailing lambda in UpdateCard bound to WarningCard's `icon` parameter instead of `onClick` since the component rewrite in 61e261d appended the icon slot after onClose. The click handler was therefore executed as a side effect during composition: every recomposition called showConfirm() and re-opened the changelog dialog, so canceling it only triggered another recomposition and the dialog could never stay closed. Pass the handler explicitly as `onClick`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trailing lambda in UpdateCard bound to WarningCard's
iconparameter instead ofonClicksince the component rewrite in 61e261d appended the icon slot after onClose. The click handler was therefore executed as a side effect during composition: every recomposition called showConfirm() and re-opened the changelog dialog, so canceling it only triggered another recomposition and the dialog could never stay closed.Pass the handler explicitly as
onClick.