VendorConfigManager implementations for dell, supermicro and asrockrack - #12
Merged
Conversation
splaspood
marked this pull request as draft
November 7, 2023 21:27
splaspood
force-pushed
the
hw-config-0
branch
from
November 14, 2023 20:46
4e4f36a to
34ae332
Compare
splaspood
marked this pull request as ready for review
December 4, 2023 17:00
splaspood
force-pushed
the
hw-config-0
branch
2 times, most recently
from
December 4, 2023 19:47
5a960f9 to
081acf9
Compare
splaspood
marked this pull request as draft
December 4, 2023 19:51
splaspood
force-pushed
the
hw-config-0
branch
4 times, most recently
from
December 4, 2023 20:05
7b363ef to
e6542bd
Compare
splaspood
force-pushed
the
hw-config-0
branch
3 times, most recently
from
December 14, 2023 15:42
3de19a8 to
b2f1dac
Compare
splaspood
force-pushed
the
hw-config-0
branch
from
December 14, 2023 15:45
b2f1dac to
e6ff36b
Compare
splaspood
marked this pull request as ready for review
March 6, 2024 16:30
DoctorVin
reviewed
Mar 11, 2024
DoctorVin
left a comment
DoctorVin
left a comment
Collaborator
There was a problem hiding this comment.
This looks reasonable as far as it goes. I do feel like some of the TODOs need a bit of a better answer (like what the current thinking is on supporting SRIOV on an arbitrary NIC on Dell, or supporting TPM/SRIOV on ARR).
IMO a README would be helpful here.
joelrebel
reviewed
Mar 19, 2024
joelrebel
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
A set of vendor config format providers that aid in the translation of hw config options from one vendor to another. (Primarily for BIOS/BMC config settings)
Checklist
The HW vendor this change applies to (if applicable)
Description for changelog/release notes
Adds a set of vendor config format providers that aid in the translation of hw config options from one vendor to another. (Primarily for BIOS/BMC config settings)