Add VendorLenovo, recognise Lenovo in FormatVendorName and FormatProductName - #28
Merged
joelrebel merged 1 commit intoJun 22, 2026
Merged
Conversation
2 tasks
joelrebel
approved these changes
Jun 22, 2026
joelrebel
left a comment
joelrebel
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this in and the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Adds a
VendorLenovoconstant, teachesFormatVendorNameto recogniseLenovo, and adds Lenovo ThinkSystem models to
FormatProductName, solibraries and tooling that import
bmc-toolbox/common(bmclib, ironlib, …)can identify and normalise Lenovo devices with the same typed constants
used for every other vendor.
This was requested while adding a Lenovo XClarity Controller (XCC) provider
to bmclib: the provider currently falls back to a local string literal
because
common.VendorLenovodid not exist.Checklist
The HW vendor this change applies to (if applicable)
Lenovo
The HW model number, product name this change applies to (if applicable)
ThinkSystem SR630 V2 (7Z71), ThinkSystem SR650 (7X06) — Manufacturer
reported by Redfish
ComputerSystemisLenovo.The BMC firmware and/or BIOS versions that this change applies to (if applicable)
Lenovo XClarity Controller (XCC), Redfish.
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
None.
Description for changelog/release notes
constants: add VendorLenovo and recognise Lenovo in FormatVendorName/FormatProductName