Fix R6: Lob webhook verification fails closed#154
Merged
Conversation
The previous handler only enforced signature verification when LOB_WEBHOOK_SECRET was set, falling open in any environment missing the secret. That contradicts the launch plan requirement to reject unverified Lob webhook payloads with 401. Now the handler returns 401 whenever the secret is missing or the signature does not match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
src/app/api/webhooks/lob/route.tsno longer accepts Lob webhook events whenLOB_WEBHOOK_SECRETis unset. The handler returns 401 in two cases:Why
Launch plan item R6 — the Lob webhook must fail closed. The previous handler only verified the signature when the secret happened to be set, which meant any environment that had not wired up the secret silently processed unsigned payloads. That defeats the purpose of webhook signing.
Risk
Low. Production must have
LOB_WEBHOOK_SECRETset (confirmed wired in Vercel envs). The only callers affected are environments missing the secret — by design.Test plan
mail_jobsCo-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com