Fix endless file reading even with a set stop event#58
Merged
Conversation
Problem: when a dlt file always has incoming dlt messages, the file reading fails to stop even when users set the stop_reading_event. Because we dont check the status of stop_reading_event while reading dlt file returns OK, so the set stop_reading_event wont be perceived Solution: while reading dlt file returns OK, we have another check of the status of stop_reading_event, so that the reading could be stopped accordingly
yen3
approved these changes
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: when a dlt file always has incoming dlt messages, the file reading fails to stop even when users set the stop_reading_event. Because we dont check the status of stop_reading_event while reading dlt file returns OK, so the set stop_reading_event wont be perceived
Solution: while reading dlt file returns OK, we have another check of the status of stop_reading_event, so that the reading could be stopped accordingly